NotificationCenterManager: Ensure filtered list manipulation is synchronized #8960
+35
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasblaesing
added
UI
mbien
approved these changes
Oct 26, 2025
Member
mbien
left a comment
mbien
left a comment
There was a problem hiding this comment.
changes look good. Couldn't come up with a scenario where a null element could have made it into the list though.
unfortunately the user didn't post the start of the log - the first exception might have looked differently (e.g ConcurrentModificationException).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manipulation requests of
filteredNotificationsare only partially covered by synchronization onnotifications. Manipulations inaddanddeletewere not protected. This might explain undefined behavior if the list is read while it is being modified.Closes: #8956