Log warning and continue on java hint failure #8982
Merged
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
mbien
force-pushed
the
continue-on-hint-failure
branch
from
98ae470 to
50e9b08
Compare
matthiasblaesing
approved these changes
Nov 9, 2025
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Makes sense to me. Preventing a single hint problem from causing problems for other hints is a good change. The hint still needs to be fixed, but that is a different problem.
I thought it might be possible to use the ErrorDescription to carry the problem to GUI, but that is not equipped to do this (from my POV at least). Using logging on warning level should give it enough exposure without causing trouble.
Thanks.
the other hints should have a chance to run too
mbien
force-pushed
the
continue-on-hint-failure
branch
from
50e9b08 to
dbfc838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the other hints should have a chance to run too