[SPARK-53148][CONNECT][SQL] Make SqlCommand in SparkConnectPlanner side effect free #51903
+173
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyihong
force-pushed
the
SPARK-53148
branch
2 times, most recently
from
43e71e2 to
c313fb7
Compare
heyihong
changed the title
heyihong
changed the title
heyihong
force-pushed
the
SPARK-53148
branch
3 times, most recently
from
c522df8 to
3814a3d
Compare
heyihong
changed the title
heyihong
force-pushed
the
SPARK-53148
branch
2 times, most recently
from
a771cd8 to
67834ee
Compare
heyihong
force-pushed
the
SPARK-53148
branch
2 times, most recently
from
6b707da to
4771a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR refactors the
SqlCommandhandling inSparkConnectPlannerto make it side-effect free by separating the transformation and execution phases. The key changes include:handleSqlCommandintotransformSqlCommand(pure transformation) andrunSQLCommand(execution with side effects)sqlParsedPlanmethods toSparkSessionto support both named and positional parameters for SQL parsing without executionWhy are the changes needed?
The
handleSqlCommandmethod performs both transformation and execution in a single phase, making it difficult to observe, reason about and testDoes this PR introduce any user-facing change?
No. This is a purely internal refactoring.
How was this patch tested?
Existing tests (e.g. SparkConnectServiceE2ESuite)
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor 1.3.9