Skip to content

[SPARK-53242][CORE][DSTREAM] Move stackTraceToString to JavaUtils and use it to replace Throwables.getStackTraceAsString #51969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Aug 11, 2025

What changes were proposed in this pull request?

This pr move stackTraceToString to JavaUtils and use it to replace Throwables.getStackTraceAsString.

Why are the changes needed?

Reuse Spark's existing error handling functions.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass Github Actions

Was this patch authored or co-authored using generative AI tooling?

No

@LuciferYang LuciferYang marked this pull request as draft August 11, 2025 06:18
@LuciferYang LuciferYang changed the title Move stackTraceToString to JavaUtils and use it to replace Throwables.getStackTraceAsString [SPARK-53242][CORE][DSTREAM] Move stackTraceToString to JavaUtils and use it to replace Throwables.getStackTraceAsString Aug 11, 2025
@LuciferYang
Copy link
Contributor Author

test first

@dongjoon-hyun
Copy link
Member

Thank you, @LuciferYang .

@LuciferYang LuciferYang marked this pull request as ready for review August 11, 2025 17:44
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @LuciferYang .
Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants