[SPARK-53707] Improve attribute metadata handling. #52449
Closed
+246
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksbeyer
changed the title
cloud-fan
reviewed
Sep 25, 2025
sql/api/src/main/scala/org/apache/spark/sql/types/Metadata.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 25, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 25, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
Outdated
Show resolved
Hide resolved
ksbeyer
force-pushed
the
SPARK-53707-better-metadata
branch
3 times, most recently
from
9c2fd9d to
e0156d8
Compare
thetasketch.sql.out is outdated expected from recursive sql changes; fixing it too
ksbeyer
force-pushed
the
SPARK-53707-better-metadata
branch
from
e0156d8 to
3c94b46
Compare
ksbeyer
changed the title
cloud-fan
approved these changes
Sep 26, 2025
|
thanks, merging to master! |
|
@ksbeyer @cloud-fan, this patch seems to have fixed another issue I'm working on #52474 (comment). I'm not sure if it's by design or just a side effect. |
|
This PR fixes attribute metadata propagation (keeps more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve how metadata is propagated during analysis and rewrites.
This PR improves metadata propagation but it doesn't solve all the problems. A thorough review is recommended. Also recommended is to make and Alias unresolved if its inferring metadata and once its child is resolved, the ineferred metadata should be made explicit. Then the metadata would be significantly more stable.
Why are the changes needed?
Wrong metadata is inferred for DML and probably other places.
Does this PR introduce any user-facing change?
Changing metadata can change DML behavior.
Not removing aliases can cause some Project operators to remain.
How was this patch tested?
Tests were added with the previous PR on this topic [SPARK-52772].
Was this patch authored or co-authored using generative AI tooling?
No