[SPARK-53720][SQL] Simplify extracting Table from DataSourceV2Relation #52460
+33
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
force-pushed
the
spark-53720
branch
from
5a7a2f9 to
7e08697
Compare
karuppayya
reviewed
Oct 2, 2025
| override protected def stringArgs: Iterator[Any] = stringArgsVal.iterator | ||
| } | ||
|
|
||
| object DataSourceV2Table { |
There was a problem hiding this comment.
nit: Since it extracts v2 table from the relation, i would prefer it to be ExtractV2Table, which makes it explict that it is just an extractor and not a top level class (like org.apache.spark.sql.catalog.Table), and follows other clases like ExtractEquiJoinKeys , ExtractJoinWithBuckets etc
There was a problem hiding this comment.
I went back and forth on this one. Probably, ExtractXXX is a bit more direct in this case. Updated.
karuppayya
approved these changes
Oct 2, 2025
aokolnychyi
force-pushed
the
spark-53720
branch
from
7e08697 to
ba656aa
Compare
cloud-fan
reviewed
Oct 10, 2025
| override protected def stringArgs: Iterator[Any] = stringArgsVal.iterator | ||
| } | ||
|
|
||
| object ExtractTable { |
cloud-fan
approved these changes
Oct 10, 2025
gengliangwang
approved these changes
Oct 10, 2025
|
Could you address the last comment, @aokolnychyi ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a new extractor for
TablefromDataSourceV2Relation.Why are the changes needed?
As we see over time,
DataSourceV2Relationcontinues to evolve and has many args. Frequently, we only need to get the table instance and are not interested in other arguments. Therefore, it makes sense to add a new extractor for this common use case. In particular, I plan to addTimeTravelSpecand I don't want to update a ton of places for no good reason.Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR relies on existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.