THRIFT-5888: Do not dynamically enable the GIL under free-threaded Python #3180
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've completed an auditing of the C extension modules and it does not appear to have any global state. Thus, we can signify that the extension does not rely on the GIL for thread safety, so that it's not dynamically reenabled when `thrift.protocal.fastbinary` is imported.
Author
|
Friendly ping on this. All of the CI failures appear to be unrelated. |
|
@lysnikolaou can you see if the failures go away when you rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've completed an auditing of the C extension modules and it does not appear to have any global state. Thus, we can signify that the extension does not rely on the GIL for thread safety, so that it's not dynamically reenabled when
thrift.protocal.fastbinaryis imported.