chore: solve some phpstan issues #7249
Open
+34
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
somePhpstan
branch
from
c72420c to
bc4a5dc
Compare
|
Around the API Platform con date for a release. I'm targeting a 4.2 alpha release in the coming weeks (it'll be a slower pace in july/august). |
VincentLanglet
changed the title
Ok, if you have time to review and if you're interested I'll have the time to fix the phpstan issues (and then bump to the level 6 by adding type everywhere). I'll already have this PR and another one #7250 |
VincentLanglet
force-pushed
the
somePhpstan
branch
from
bc4a5dc to
d9904d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #7239
I'll do small PR for easier review.
Here the main fix are the
return.unusedTypereporting return type which can be remove from return type ONLY ON FINAL CLASS, so it's a backward compatible change which give a more precise return type for users.Do you have an ETA for 4.2 @soyuka ? I'll try to fix as many as possible phpstan issues before.