[DRAFT] Add more details to VPC Connection request #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saswatp
reviewed
May 6, 2024
Member
saswatp
left a comment
saswatp
left a comment
There was a problem hiding this comment.
let's not use connection name and derive the name . I believe that's the implementation across other provider connectivity. Let's keep the behavior consistent across all providers. This also needs significant testing across all
For Azure VPC Connectivity development, it was helpful to add a few more information regarding VPCs in Azure.
iosetek
force-pushed
the
azure-connectivity
branch
from
f212c7b to
cde4053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Azure VPC Connectivity development, it was helpful to add a few more information regarding VPCs in Azure.
This change may require further development