Fix ListVPCs method for AWI Domain Connector #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awi-CLI and Awi-UI use awi-infra-guard codebase for listing most resources including VPCs. However, kube-awi uses older API from awi-grpc-catalyst-sdwan rather than awi-infra-guard. Currently, most of methods from awi-grpc-catalyst-sdwan are forwarded to awi-infra-guard anyway, but ListVPCs is not and it was implemented to return empty list of VPCs if the connector was not VManage. This change fixes it by using awi-infra-guard if the connector is different than VManage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awi-CLI and Awi-UI use awi-infra-guard codebase for listing most resources including VPCs. However, kube-awi uses older API from awi-grpc-catalyst-sdwan rather than awi-infra-guard.
Currently, most of methods from awi-grpc-catalyst-sdwan are forwarded to awi-infra-guard anyway, but ListVPCs is not and it was implemented to return empty list of VPCs if the connector was not VManage.
This change fixes it by using awi-infra-guard if the connector is different than VManage.