QR amount input #105
Open
QR amount input #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the PR. The feature was already suggested before a couple of times and we have an implementation in mind (which we couldn't get to implementing yet). Since we prefer that implementation over this one, we won't be merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an amount input field to the receive sheet so it can be prefilled by the scanning device. The feature was suggested here
The current QR implementation creates the QR widget ahead of time and passes it into the receive sheet for performance reasons. I decided to keep it like this for the initial render. The QR widget is redrawn as the user enters the amount. I also tested only redrawing on blur/enter, but it didn't feel as nice IMO. If there is another approach that is preferable to this, let me know!
The input supports both NANO and local currency inputs which is converted to raw on the fly. This should be especially useful as a POS device for merchants with items listed in their native currency, since no separate currency calculation is needed.