http-netty: use DefaultLoadBalancer API's #3350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Motivation We have been using the RoundRobinLoadBalancers API's for a while which give us the ability to switch the default back to RoundRobinLoadBalancer if we have an emergency. DefaultLoadBalancer has been the default now for quite a while so lets cut over to the new API's and get off the deprecated ones. #### Modifications Switch to the new API's. #### Result Less deprecated usages.
bryce-anderson
commented
Oct 17, 2025
...ttp-netty/src/main/java/io/servicetalk/http/netty/DefaultSingleAddressHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Oct 17, 2025
bryce-anderson
force-pushed
the
bl_anderson/rm-RR-usages
branch
from
6621488 to
21a3180
Compare
|
|
||
| /** | ||
| * {@link OutlierDetectorConfig} that disables all outlier detection. | ||
| * @return the {@link OutlierDetectorConfig} |
There was a problem hiding this comment.
Suggested change
| * @return the {@link OutlierDetectorConfig} | |
| * @return the {@link OutlierDetectorConfig} that disables all outlier detection. |
| * The configuration values can be used as a base layer for configuration and then modified using the | ||
| * {@link OutlierDetectorConfig.Builder} constructor as follows: | ||
| * <pre>{@code | ||
| * OutlierDetectorConfig config = new OutlierDetectorConfig.Builder(disabled()) |
There was a problem hiding this comment.
This copy constructor is not public
There was a problem hiding this comment.
Also, consider adding @link or @see to OutlierDetectorConfigs from OutlierDetectorConfig and OutlierDetectorConfig.Builder javadoc
|
|
||
| /** | ||
| * {@link OutlierDetectorConfig} that only enables the default consecutive connection failure detection. | ||
| * @return the {@link OutlierDetectorConfig} |
There was a problem hiding this comment.
Suggested change
| * @return the {@link OutlierDetectorConfig} | |
| * @return the {@link OutlierDetectorConfig} that only enables the default consecutive connection failure detection. |
| * {@link OutlierDetectorConfig} that only enables the default consecutive connection failure detection. | ||
| * @return the {@link OutlierDetectorConfig} | ||
| */ | ||
| public static OutlierDetectorConfig l4Only() { |
There was a problem hiding this comment.
Do you have any other name ideas for this one? WDYT about onlyConnectFailures()? l4 might be a bit encryptive for some users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have been using the RoundRobinLoadBalancers API's for a while which give us the ability to switch the default back to RoundRobinLoadBalancer if we have an emergency. DefaultLoadBalancer has been the default now for quite a while so lets cut over to the new API's and get off the deprecated ones.
Modifications
Switch to the new API's.
Result
Less deprecated usages.