Skip to content

Conversation

HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Sep 25, 2025

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

image

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Bug Fixes
    • Improves visual stability by reserving space for the vertical scrollbar to prevent content shifting when pages begin or stop scrolling. Reduces layout jumpiness across browsers and OS configurations; purely a rendering/appearance improvement with no change to app behavior or performance.

Copy link

appwrite bot commented Sep 25, 2025

Console

Project ID: 688b7bf400350cbd60e9

Sites (2)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Building Building View Logs Preview URL QR Code
 console-cloud
688b7c18002b9b871a8f
Ready Ready View Logs Preview URL QR Code

Note

You can use Avatars API to generate QR code for any text or URLs.

Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

Walkthrough

Adds a global CSS rule in src/routes/+layout.svelte applying scrollbar-gutter: auto !important to the html element to reserve gutter space when a vertical scrollbar is absent. Change affects layout/rendering only; there are no modifications to runtime logic, control flow, or exported/public entities.

Suggested reviewers

  • lohanidamodar
  • eldadfux
  • ItzNotABug

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title contains a double negative (“when no vertical scrollbar is not present”) and is grammatically confusing, making it unclear. It also misstates the change, which actually adds a CSS rule to reserve the scrollbar gutter to prevent layout shifts. A clearer title should focus on reserving gutter space when the scrollbar is absent. Rewrite the title to clearly and concisely reflect the main change, for example: “Reserve scrollbar gutter to prevent layout shift when vertical scrollbar is absent.”
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-remove-space-right-end-when-no-scrollbar

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a511c1d and 2b8b5e5.

📒 Files selected for processing (1)
  • src/routes/+layout.svelte (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/routes/+layout.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: e2e
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HarshMN2345 HarshMN2345 changed the title Fix: remove phantom right-edge spacing when no vertical scrollbar is… Fix: remove right-edge spacing when no vertical scrollbar is not present Sep 25, 2025
/* Fix when no vertical scrollbar is present, some environments reserve a gutter by default */
html,
body {
scrollbar-gutter: auto !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is !important needed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is needed here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats overriding that behaviour? can we know? would give us an idea as well as to whats actually wrong.
cc @TorstenDittmann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants