-
Notifications
You must be signed in to change notification settings - Fork 190
Redesign authorize contributor page #2406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ConsoleProject ID: Sites (2)
Note Cursor pagination performs better than offset pagination when loading further pages. |
WalkthroughThe git route layout replaces the Container with a full-viewport .auth-bg wrapper containing a section for the console slot and a footer showing “POWERED BY” with a theme-dependent Appwrite logo. It imports base from $app/paths, app store, and Typography, and removes the Container import. Image sources now prefix with base and switch by theme. New SCSS styles fix positioning and responsive layout. The authorize-contributor page refactors UI to @appwrite.io/pink-svelte components (Layout, Typography, Badge, Button), centralizes content, removes logos/footer, and keeps approveDeployment logic with updated message rendering and button handling. Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/routes/(authenticated)/git/authorize-contributor/+page.svelte (1)
1-68
: Fix Prettier formatting.The pipeline reports that this file fails the Prettier formatting check. Run
prettier --write
to fix formatting issues before merging.#!/bin/bash # Fix Prettier formatting for this file prettier --write "src/routes/(authenticated)/git/authorize-contributor/+page.svelte"
🧹 Nitpick comments (1)
src/routes/(authenticated)/git/+layout.svelte (1)
18-30
: Consider consolidating the theme-based image logic.The conditional blocks for dark/light logos are nearly identical. Consider extracting the image path to a reactive statement for cleaner code.
Example refactor:
+ $: logoSrc = `${base}/images/appwrite-logo-${$app.themeInUse === 'dark' ? 'dark' : 'light'}.svg`; + <footer> <Typography.Eyebrow color="--fgcolor-neutral-secondary">POWERED BY</Typography.Eyebrow> - {#if $app.themeInUse === 'dark'} - <img - src="{base}/images/appwrite-logo-dark.svg" - width="120" - height="22" - alt="Appwrite Logo" /> - {:else} - <img - src="{base}/images/appwrite-logo-light.svg" - width="120" - height="22" - alt="Appwrite Logo" /> - {/if} + <img + src={logoSrc} + width="120" + height="22" + alt="Appwrite Logo" /> </footer>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/routes/(authenticated)/git/+layout.svelte
(1 hunks)src/routes/(authenticated)/git/authorize-contributor/+page.svelte
(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Tests
src/routes/(authenticated)/git/+layout.svelte
[error] 1-1: Prettier formatting check failed for this file. Run 'prettier --write' to fix code style issues.
src/routes/(authenticated)/git/authorize-contributor/+page.svelte
[error] 1-1: Prettier formatting check failed for this file. Run 'prettier --write' to fix code style issues.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
🔇 Additional comments (2)
src/routes/(authenticated)/git/authorize-contributor/+page.svelte (2)
30-51
: LGTM! Deployment approval logic is solid.The
approveDeployment
function correctly:
- Prevents concurrent calls via the loading guard
- Clears previous messages before each attempt
- Handles success and error cases appropriately
- Maintains proper loading state in finally block
54-68
: Confirm style prop forwarding in Layout.Stack
Please verify that theLayout.Stack
component from pink-svelte forwards thestyle
attribute to its rendered DOM element; if it doesn’t, wrap it in a container or update the component to accept and apply thestyle
prop.
Related task: https://linear.app/appwrite/issue/SER-213/forked-prs-autorization-page-broken
Summary by CodeRabbit
Style
Refactor