-
Notifications
You must be signed in to change notification settings - Fork 191
fix: Resolve issues in Messaging screens #2422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
801eed8
move filters button to right side and fix search placeholder
HarshMN2345 b8a472f
lint issue
HarshMN2345 69d2cd6
removed button and using link in updateTopics
HarshMN2345 5cb9b63
Unnecessary padding above Name input
HarshMN2345 448ab66
Remove unnecessary extra spacing here
HarshMN2345 dbee85e
Read the guide in the docs should open a new tab
HarshMN2345 13c68f0
Add wizard footer with Create button (Currently we have a divider and…
HarshMN2345 a41cfd8
fix subscribers screen
HarshMN2345 8a9efc1
fixed the width of provider popup
HarshMN2345 77b01de
fixed align action menu issue
HarshMN2345 6bfa007
refactor the flow for push notifcations
HarshMN2345 3393329
Fix topics modal target counts based on provider typr
HarshMN2345 71997d2
remove any
HarshMN2345 fde78df
improvements
HarshMN2345 ce3d0e0
done changes liek replacing anchor with Links and removing bad empty …
HarshMN2345 8ea21ad
lint issue
HarshMN2345 920d4f7
svelte 5 migartion
HarshMN2345 c470fc4
lint error
HarshMN2345 33db74b
clarify effect deps
HarshMN2345 7f5c0df
replace div with Layout.Stack in popoverContent and inline maxWidth s…
HarshMN2345 3c434ac
Update src/routes/(console)/project-[region]-[project]/messaging/topi…
HarshMN2345 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 21 additions & 27 deletions
48
src/routes/(console)/project-[region]-[project]/messaging/providers/+page.svelte
HarshMN2345 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 9 additions & 2 deletions
11
src/routes/(console)/project-[region]-[project]/messaging/providers/popoverContent.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,28 @@ | ||
<script lang="ts"> | ||
import { ImagePreview } from '$lib/components'; | ||
import { Layout } from '@appwrite.io/pink-svelte'; | ||
export let lines = []; | ||
export let image: { src: { dark: string; light: string }; alt: string } | null = null; | ||
</script> | ||
|
||
<div class="u-flex-vertical u-gap-16"> | ||
<div class="u-flex-vertical u-gap-16 popover-content"> | ||
|
||
{#each lines as line} | ||
<p>{@html line}</p> | ||
{/each} | ||
|
||
{#if image} | ||
<ImagePreview darkSrc={image.src.dark} lightSrc={image.src.light} alt={image.alt} /> | ||
<Layout.Stack class="image-wrapper"> | ||
HarshMN2345 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
<ImagePreview darkSrc={image.src.dark} lightSrc={image.src.light} alt={image.alt} /> | ||
</Layout.Stack> | ||
{/if} | ||
</div> | ||
|
||
<style> | ||
.popover-content { | ||
max-inline-size: 260px; | ||
} | ||
div > p { | ||
color: hsl(var(--color-neutral-50)); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.