Feature/add mis endpoints in col #695
Open
+588
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwierzbo
requested changes
Jul 30, 2025
bluepal-prasanthi-moparthi
force-pushed
the
feature/add_mis_endpoints_in_col
branch
from
8751904 to
307a260
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds several missing collection-related API endpoints to the v2 client library, expanding collection management capabilities. The implementation includes 9 new endpoints for collection statistics, revision tracking, checksum calculations, shard management, index operations, renaming, count recalculation, and compaction.
- Implements collection statistics, revision, checksum, and shard management endpoints
- Adds index loading, collection renaming, count recalculation, and compaction operations
- Includes comprehensive test coverage for all new endpoints with proper environment validation
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| v2/arangodb/collection.go | Adds method signatures for 8 new collection operations |
| v2/arangodb/collection_impl.go | Implements the collection endpoint methods with proper HTTP handling |
| v2/arangodb/collection_opts.go | Defines request/response structs for new collection operations |
| v2/arangodb/database.go | Adds KeyGenerators method to Database interface |
| v2/arangodb/database_impl.go | Implements KeyGenerators endpoint for database |
| v2/arangodb/database_opts.go | Defines KeyGeneratorsResponse struct |
| v2/tests/database_collection_operations_test.go | Comprehensive test coverage for all new collection endpoints |
| v2/tests/database_transactions_test.go | Test for database KeyGenerators endpoint |
| v2/tests/graph_helper_test.go | Updates graph helper to include database name in graph naming |
| v2/CHANGELOG.md | Documents the addition of missing collection endpoints |
Comments suppressed due to low confidence (1)
v2/arangodb/collection_opts.go:400
- [nitpick] The struct ResponsibleShardRequest has a field 'Key' but the JSON tag is '_key'. This inconsistency could be confusing. Consider renaming the field to match the JSON convention or vice versa.
Key string `json:"_key,omitempty"`
v2/arangodb/collection_impl.go
Outdated
Comment on lines
277
to
280
| if *withRevisions { | ||
| modifiers = append(modifiers, connection.WithQuery("withRevisions", boolToString(*withRevisions))) | ||
| } | ||
| if *withData { |
There was a problem hiding this comment.
Potential nil pointer dereference. The function should check if withRevisions is nil before dereferencing it.
Suggested change
| if *withRevisions { | |
| modifiers = append(modifiers, connection.WithQuery("withRevisions", boolToString(*withRevisions))) | |
| } | |
| if *withData { | |
| if withRevisions != nil && *withRevisions { | |
| modifiers = append(modifiers, connection.WithQuery("withRevisions", boolToString(*withRevisions))) | |
| } | |
| if withData != nil && *withData { |
Copilot uses AI. Check for mistakes.
v2/arangodb/collection_impl.go
Outdated
Comment on lines
277
to
280
| if *withRevisions { | ||
| modifiers = append(modifiers, connection.WithQuery("withRevisions", boolToString(*withRevisions))) | ||
| } | ||
| if *withData { |
There was a problem hiding this comment.
Potential nil pointer dereference. The function should check if withData is nil before dereferencing it.
Suggested change
| if *withRevisions { | |
| modifiers = append(modifiers, connection.WithQuery("withRevisions", boolToString(*withRevisions))) | |
| } | |
| if *withData { | |
| if withRevisions != nil && *withRevisions { | |
| modifiers = append(modifiers, connection.WithQuery("withRevisions", boolToString(*withRevisions))) | |
| } | |
| if withData != nil && *withData { |
Copilot uses AI. Check for mistakes.
|
|
||
| result, err := col.Compact(ctx) | ||
| require.NoError(t, err) | ||
| fmt.Printf("Compacted Collection: %s, ID: %s, Status: %d\n", result.Name, result.ID, result.Status) |
There was a problem hiding this comment.
Using fmt.Printf in tests is not recommended. Consider using t.Logf() instead for proper test logging.
Suggested change
| fmt.Printf("Compacted Collection: %s, ID: %s, Status: %d\n", result.Name, result.ID, result.Status) | |
| t.Logf("Compacted Collection: %s, ID: %s, Status: %d", result.Name, result.ID, result.Status) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the following collection-related endpoints: