-
Notifications
You must be signed in to change notification settings - Fork 73
[Feature] [Platform] Storage Debug #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// | ||
// DISCLAIMER | ||
// | ||
// Copyright 2025 ArangoDB GmbH, Cologne, Germany | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
// Copyright holder is ArangoDB GmbH, Cologne, Germany | ||
// | ||
|
||
package v1 | ||
|
||
import "time" | ||
|
||
type Configuration struct { | ||
Debug ConfigurationDebug `json:"debug,omitempty"` | ||
} | ||
|
||
type ConfigurationDebug struct { | ||
Enabled bool `json:"enabled,omitempty"` | ||
|
||
Path string `json:"path,omitempty"` | ||
|
||
Timeout time.Duration `json:"timeout,omitempty"` | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// | ||
// DISCLAIMER | ||
// | ||
// Copyright 2025 ArangoDB GmbH, Cologne, Germany | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
// Copyright holder is ArangoDB GmbH, Cologne, Germany | ||
// | ||
|
||
package v1 | ||
|
||
import "github.com/arangodb/kube-arangodb/pkg/logging" | ||
|
||
var logger = logging.Global().RegisterAndGetLogger("integration-shutdown-v1", logging.Info) |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -23,6 +23,7 @@ package definition | |||||||
import ( | ||||||||
"context" | ||||||||
"io" | ||||||||
"os" | ||||||||
|
||||||||
"github.com/arangodb/kube-arangodb/pkg/util" | ||||||||
"github.com/arangodb/kube-arangodb/pkg/util/errors" | ||||||||
|
@@ -31,6 +32,26 @@ import ( | |||||||
|
||||||||
const BufferSize = 4094 | ||||||||
|
||||||||
func SendFile(ctx context.Context, client StorageV2Client, key string, path string) (*StorageV2WriteObjectResponse, error) { | ||||||||
f, err := os.Open(path) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. File handle opened with os.Open is not closed on successful Send; add Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||
if err != nil { | ||||||||
return nil, err | ||||||||
} | ||||||||
|
||||||||
defer f.Close() | ||||||||
|
||||||||
p, err := Send(ctx, client, key, f) | ||||||||
if err != nil { | ||||||||
if cerr := f.Close(); cerr != nil { | ||||||||
return nil, cerr | ||||||||
} | ||||||||
|
||||||||
Comment on lines
+45
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The explicit
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||
return nil, err | ||||||||
} | ||||||||
|
||||||||
return p, nil | ||||||||
} | ||||||||
|
||||||||
func Send(ctx context.Context, client StorageV2Client, key string, in io.Reader) (*StorageV2WriteObjectResponse, error) { | ||||||||
cache := make([]byte, BufferSize) | ||||||||
|
||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file opened here is not closed on the successful path. Consider using
defer f.Close()
immediately after opening to avoid a file descriptor leak.Copilot uses AI. Check for mistakes.