-
Notifications
You must be signed in to change notification settings - Fork 73
[Feature] Improve Session Handling #1964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// | ||
// DISCLAIMER | ||
// | ||
// Copyright 2024 ArangoDB GmbH, Cologne, Germany | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
// Copyright holder is ArangoDB GmbH, Cologne, Germany | ||
// | ||
|
||
syntax = "proto3"; | ||
|
||
package shared; | ||
|
||
option go_package = "github.com/arangodb/kube-arangodb/integrations/shared/v1/definition"; | ||
|
||
// Path Error Details | ||
message PathError { | ||
// Path | ||
string path = 1; | ||
// Message | ||
string message = 2; | ||
} | ||
|
||
// Path Error Details | ||
message Error { | ||
// Message | ||
string message = 1; | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,7 @@ import ( | |
"fmt" | ||
"io" | ||
|
||
pbSharedV1 "github.com/arangodb/kube-arangodb/integrations/shared/v1/definition" | ||
"github.com/arangodb/kube-arangodb/pkg/util/errors" | ||
) | ||
|
||
|
@@ -32,6 +33,13 @@ type ResourceError struct { | |
Err error | ||
} | ||
|
||
func (p ResourceError) AsGRPCError() *pbSharedV1.PathError { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Method name 'AsGRPCError' doesn't match the interface 'AsGRCPError' defined in grpc/errors.go. Either fix the interface name or this method name to maintain consistency. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
return &pbSharedV1.PathError{ | ||
Path: p.Prefix, | ||
Message: p.Err.Error(), | ||
} | ||
} | ||
Comment on lines
+36
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The method returns a pointer to Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
|
||
// Error return string representation of error | ||
func (p ResourceError) Error() string { | ||
return fmt.Sprintf("%s: %s", p.Prefix, p.Err.Error()) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code calls
i.session.Refresh()
but ignores the returned duration (third parameter with_
). This duration represents the time until session expiration and should be used to make informed decisions about whether refresh is needed or to set appropriate cache headers.Copilot uses AI. Check for mistakes.