Introduce concepts for AccessTraits #1253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
commented
May 3, 2025
| template <typename Traits> | ||
| using AccessTraitsMemorySpaceArchetypeAlias = typename Traits::memory_space; | ||
| template <class T, class U> | ||
| concept not_same_as = !std::same_as<T, U>; |
There was a problem hiding this comment.
I added this because there does not seem to be a non-void concept in std, and !std::same_as<void> did not work.
|
@dalg24 Could you please take a look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch introduces three concepts:
AccessTraits,Primitives(same asAccessTraits) andPredicates(AccessTraits+ tag). I put them intoConceptsnamespace.In general, it works fine. One corner point is how it interacts with CTAD.
clangevaluates the right hand side of CTAD before testing the concept, which leads to suboptimal errors instead of ignoring the CTAD (see godbolt). GCC, on the other hand, has a better treatment and properly rejects CTAD due to the unsatisfied requirement.