Fix a bug where predicate helper functions needed memory_space type in the type #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the type Predicate helpers were using `UserPrimitives::memory_space` inside `AccessTraits` specializations instead of getting it through corresponding traits. This meant that even if the corresponding `AccessTraits` was written correctly, it did not work
aprokop
force-pushed
the
fix_predicate_helpers
branch
from
8f909ad to
2cb560f
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Predicate helpers were using
UserPrimitives::memory_spaceinsideAccessTraitsspecializations instead of getting it through corresponding traits. This meant that even if the correspondingAccessTraitswas written correctly, it did not work.