refactor: Convert conversationHandlers to async/await syntax #2072
+181
−167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors
frontend/src/conversation/conversationHandlers.ts
from legacy.then()
chaining to modernasync/await
syntax for improved code maintainability and readability.Fixes #2070
Changes Made
Refactored Functions (7 total):
handleFetchAnswer
- Main answer fetching handlerhandleFetchAnswerSteaming
- Streaming response handlerhandleSearch
- Document search handlerhandleSearchViaApiKey
- API key-based search handlerhandleSendFeedback
- User feedback submission handlerhandleFetchSharedAnswerStreaming
- Shared conversation streaming handlerhandleFetchSharedAnswer
- Shared conversation answer handlerKey Improvements:
.then()
chains withasync/await
for linear, readable code flowtry/catch
blocks instead of.catch()
toolCalls
type tohandleFetchSharedAnswer
return typethrow
statementsTesting
Code Quality
Type of Change
Checklist