Add ability to stop "step" routine #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In one of my projects, I needed to stop the "steps" routine with an interruption. I just put and bool flag to keep it looping. Maybe someone else will find it interesting
In one of my projects, I needed to stop the "steps" routine with an interruption. I just put and bool flag to keep it looping. Maybe someone else will find it interesting
In one of my projects, I needed to stop the "steps" routine with an interruption. I just put and bool flag to keep it looping. Maybe someone else will find it interesting
|
Just to link things together, here's the previous pull request that was requested to be moved to this repository: arduino/Arduino#6420 |
|
I don't see how one is expected to use this... Is there some auuino out there with preemptive multithreading to call the stop() method from another thread? Even if there was, you'd then need to mark this->set_stop as volatile in some way to prevent the whole thing being elided by an optimizing compiler... |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something like "emergency stop"
i found it very useful to stop the motor but keep the coils magnetized to stop asap the motor, because if you only power off, it can continue spinning with inertia.