Skip to content

Provide for support for ZeroConf/Bonjour #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Provide for support for ZeroConf/Bonjour #3689

wants to merge 1 commit into from

Conversation

lathoub
Copy link
Contributor

@lathoub lathoub commented Aug 16, 2015

Provide for support for ZeroConf/Bonjour, by allowing derived classes
access to _sock and _remaining. See
https://github.com/lathoub/EthernetBonjour

Provide for support for ZeroConf/Bonjour, by allowing derived classes
access to _sock and _remaining. See
https://github.com/lathoub/EthernetBonjour
@cmaglie cmaglie added Library: Ethernet The Ethernet Arduino library feature request A request to make an enhancement (not a bug fix) labels Aug 17, 2015
@cmaglie cmaglie added this to the Release 1.6.6 milestone Aug 17, 2015
@cmaglie
Copy link
Member

cmaglie commented Aug 17, 2015

I see that you use _sock only in beginMulti method:

https://github.com/lathoub/EthernetBonjour/blob/master/EthernetBonjour.cpp#L167

but this method has been recently merged upstream and named beginMulticast:

e580592

can you use this method so we can avoid to expose the _sock field?

@lathoub
Copy link
Contributor Author

lathoub commented Aug 17, 2015

e580592 looks good from my perspective, avoids exposing both _sock and _remaining. This is great! I shall close this issue, delete my pull request and await 1.6.6.

@lathoub lathoub closed this Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request to make an enhancement (not a bug fix) Library: Ethernet The Ethernet Arduino library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants