-
Notifications
You must be signed in to change notification settings - Fork 39
feat: Populate cluster cache info in principal #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 44.86% 45.10% +0.24%
==========================================
Files 88 88
Lines 10795 10945 +150
==========================================
+ Hits 4843 4937 +94
- Misses 5565 5618 +53
- Partials 387 390 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3cc76f4
to
a2f6277
Compare
jgwest
requested changes
Aug 15, 2025
a2f6277
to
6c9540c
Compare
6c9540c
to
5092e9c
Compare
jgwest
requested changes
Aug 19, 2025
85166b1
to
a79d8d7
Compare
jgwest
requested changes
Aug 20, 2025
4c34bf7
to
917af65
Compare
jgwest
requested changes
Aug 21, 2025
Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
917af65
to
d789bf0
Compare
jgwest
requested changes
Aug 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jparsai!
jgwest
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add logic to populate cluster cache info in principal from managed agent. The agent will also send periodic events to principal to keep it updated about any changes in managed cluster cache. The principal will receive and update the control-plane cache. The UI running on control-plane will read the info and display it along with other details.
Fixes: #418