Skip to content

Conversation

jparsai
Copy link
Collaborator

@jparsai jparsai commented Aug 14, 2025

This PR is to add logic to populate cluster cache info in principal from managed agent. The agent will also send periodic events to principal to keep it updated about any changes in managed cluster cache. The principal will receive and update the control-plane cache. The UI running on control-plane will read the info and display it along with other details.

Fixes: #418

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 59.27835% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.10%. Comparing base (edfedbd) to head (d789bf0).

Files with missing lines Patch % Lines
internal/argocd/cluster/cluster.go 73.17% 15 Missing and 7 partials ⚠️
agent/agent.go 23.52% 12 Missing and 1 partial ⚠️
internal/event/event.go 0.00% 13 Missing ⚠️
agent/outbound.go 75.75% 6 Missing and 2 partials ⚠️
cmd/argocd-agent/agent.go 0.00% 7 Missing ⚠️
internal/argocd/cluster/manager.go 41.66% 6 Missing and 1 partial ⚠️
agent/options.go 0.00% 5 Missing ⚠️
internal/manager/application/application.go 0.00% 2 Missing ⚠️
principal/event.go 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   44.86%   45.10%   +0.24%     
==========================================
  Files          88       88              
  Lines       10795    10945     +150     
==========================================
+ Hits         4843     4937      +94     
- Misses       5565     5618      +53     
- Partials      387      390       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jparsai jparsai force-pushed the cluster-cache-info branch 2 times, most recently from 3cc76f4 to a2f6277 Compare August 14, 2025 12:07
@jparsai jparsai force-pushed the cluster-cache-info branch from a2f6277 to 6c9540c Compare August 18, 2025 14:10
@jparsai jparsai marked this pull request as ready for review August 18, 2025 14:45
@jparsai jparsai force-pushed the cluster-cache-info branch from 6c9540c to 5092e9c Compare August 18, 2025 15:10
@jparsai jparsai force-pushed the cluster-cache-info branch 3 times, most recently from 85166b1 to a79d8d7 Compare August 19, 2025 13:06
@jparsai jparsai force-pushed the cluster-cache-info branch 2 times, most recently from 4c34bf7 to 917af65 Compare August 20, 2025 11:02
Assisted by: Cursor

Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
@jparsai jparsai force-pushed the cluster-cache-info branch from 917af65 to d789bf0 Compare August 25, 2025 08:44
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jparsai!

@jgwest jgwest merged commit c0c4b26 into argoproj-labs:main Aug 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate cluster cache info
4 participants