-
Notifications
You must be signed in to change notification settings - Fork 39
feat: sync private repository secrets to managed agents #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
==========================================
- Coverage 45.16% 44.23% -0.93%
==========================================
Files 88 89 +1
Lines 10945 11757 +812
==========================================
+ Hits 4943 5201 +258
- Misses 5611 6129 +518
- Partials 391 427 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm just testing this PR locally, and most of the things work really great. I noticed one thing:
|
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> Assisted-by: Cursor
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
c1d2e85
to
2ec11ef
Compare
@jannfis I've fixed the resync issue. Also added a few e2e tests to verify the resyncing of AppProject/Repository on restarts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Awesome PR, @chetan-rns 🙇
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #474
How to test changes / Special notes to the reviewer:
Checklist