feat: port Kuttl E2E tests to Ginkgo #1811
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgwest
commented
Aug 6, 2025
| ) | ||
|
|
||
| require ( | ||
| cloud.google.com/go/compute/metadata v0.6.0 // indirect |
There was a problem hiding this comment.
- Added back the
replace ( ... )block from Argo CD due to this error ongo mod tidy:
[jgw@localhost-lan argocd-operator]$ go mod tidy
go: downloading github.com/onsi/ginkgo/v2 v2.22.0
go: downloading cloud.google.com/go/compute v1.23.3
go: downloading github.com/elazarl/goproxy v0.0.0-20180725130230-947c36da3153
go: downloading github.com/rogpeppe/go-internal v1.13.1
go: downloading github.com/golang/mock v1.2.0
go: downloading github.com/google/pprof v0.0.0-20241029153458-d1b30febd7db
go: downloading cloud.google.com/go v0.38.0
go: github.com/argoproj-labs/argocd-operator/tests/ginkgo/fixture/application imports
github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1 imports
github.com/argoproj/argo-cd/v3/util/git imports
golang.org/x/oauth2/google imports
cloud.google.com/go/compute/metadata: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
cloud.google.com/go v0.38.0 (/home/jgw/go/pkg/mod/cloud.google.com/go@v0.38.0/compute/metadata)
cloud.google.com/go/compute/metadata v0.6.0 (/home/jgw/go/pkg/mod/cloud.google.com/go/compute/metadata@v0.6.0)
jgwest
force-pushed
the
port-to-ginkgo-july-2025
branch
4 times, most recently
from
34e1d8d to
c3236fb
Compare
nmirasch
reviewed
Aug 12, 2025
jgwest
force-pushed
the
port-to-ginkgo-july-2025
branch
from
c3236fb to
ff31e38
Compare
Signed-off-by: Jonathan West <jonwest@redhat.com>
jgwest
force-pushed
the
port-to-ginkgo-july-2025
branch
from
ff31e38 to
61378d0
Compare
|
|
||
| # go-get-tool will 'go install' any package $2 and install it to $1. | ||
| PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST)))) | ||
| define go-get-tool |
There was a problem hiding this comment.
I suggest extracting the shell portion of this size and complexity into an independent /hack/ script. Enables proper formatting, IDE syntax highlight, use static analysis, bash strict mode usage, etc.
nmirasch
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
replace ( ... )block ingo.mod(it's from Argo CDgo.mod) due to error ongo mod tidy(see review comment)Have you updated the necessary documentation?