Skip to content

fix: Update checkPermissions to not exit the namespace loop after the first namespace regardless #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Update checkPermissions to not exit the namespace loop after the first namespace regardless #784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pkg/cache/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,10 +845,9 @@ func (c *clusterCache) checkPermission(ctx context.Context, reviewInterface auth
if resp != nil && resp.Status.Allowed {
return true, nil
}
// unsupported, remove from watch list
//nolint:staticcheck //FIXME
return false, nil
}
// unsupported, remove from watch list
return false, nil
}
// checkPermission follows the same logic of determining namespace/cluster resource as the processApi function
// so if neither of the cases match it means the controller will not watch for it so it is safe to return true.
Expand Down