Devices/laser #33
Merged
Devices/laser #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at save a stack of tics when tic function is called and delete from the stack when toc function is called. This improvement simplify the management of time inside the devices. Now just a tic() at the begining and a toc() at the end is needed.
…e and RIN noise refact: update tic() and toc() calls in devices. BREAKING: SAMPLER device don't accept anymore `_eye_` parameter, `instant` parameter is now accepted.
…mprove decision-making process
…utput for unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
opticomliblibrary, focusing on adding new functionality, improving existing functions, and refactoring code for better performance and readability. The most important changes include adding a newLASERfunction, refactoring the timing functions, and updating various signal processing functions to improve execution time handling.New Functionality:
LASERfunction to theopticomlib/devices.pyfile, providing a model for a continuous wave laser with phase and RIN noises.Refactoring and Improvements:
_Timerclass and updating theticandtocfunctions to use this class for better management of timing operations. [1] [2] [3]MZM,BPF,EDFA,DM,LPF,PD,GET_EYE,SAMPLER,DSP) to improve execution time handling by consistently usingtoc()for timing. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]shorth_intfunction fromGET_EYEand replaced its usage withshortest_intfor estimating intervals. [1] [2]Minor Changes:
sphinx_copybuttonto the list of Sphinx extensions indocs/source/conf.pyfor better documentation.idbm,dbm) and updated the device list to includeLASERinopticomlib/devices.py. [1] [2]