Fix symbolic link preview #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to treat link as a specific case and distinguish from a real folder. 
|
|
Final touch to show where the link goes. 
|
|
@artgris I think the PR is ready. 🙂 Let me know if you have some feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #155, this patch fixes the case when a symbolic link is listed.
It follows the link and calls
previewrecursively with the real path.The drawback is that the real file or directory name will be printed out instead of the symlink.
The other solution I could provide is to return the same array as the dir case but with another html value to distinguish link from a standard dir.
The only caution I see is an infiniteloop of link, but this would be due to user error on its link rather than the code itself.