Skip to content

Make :params available for for_action() with test and add :params' document for all for_* actions #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Make :params available for for_action() with test and add :params' document for all for_* actions #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
33e14df
Add a generic action form test in form_test.exs
iyjim May 11, 2025
a2c72bc
add :params document and fix 'for_action()'s :params option' issue
iyjim May 12, 2025
cec6937
Tune the test added yesterday
iyjim May 12, 2025
76d28e1
Merge branch 'ash-project:main' into main
iyjim May 13, 2025
6c177fb
Remove duplicate :params item in drop_drom_opts() function
iyjim May 13, 2025
fa36272
Update generic actions tests
iyjim May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/ash_phoenix/form/form.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,13 @@ defmodule AshPhoenix.Form do
tenant: [
type: :any,
doc: "The current tenant. Passed through to the underlying action."
],
params: [
type: :any,
default: %{},
doc: """
The initial parameters to use for the form. This is useful for setting up a form with default values.
"""
]
]

Expand Down
11 changes: 10 additions & 1 deletion test/form_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,19 @@ defmodule AshPhoenix.FormTest do

assert 0 =
Post
|> Form.for_action(:post_count, params: params)
|> Form.for_action(:post_count)
|> Form.validate(params)
|> Form.submit!(params: params)
end

test "generic actions can accept initial params" do
params = %{containing: "hello"}

assert 0 =
Post
|> Form.for_action(:post_count, params: params)
|> Form.submit!(params: nil)
end
end

describe "drop_param" do
Expand Down