Skip to content

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Apr 21, 2025

Add tests for the scenario fixed in a8c192e
Fix the issue when reproduced in pnpm v9+

FWIW I was trying to understand when this pnpm <v9 id field is used and no tests failed when removing it. It seems it is declared in pnpm <v9 when file: or link: dependencies have peer dependencies, the id will be the file: path without the peer dependency information.

The ugly v9 workaround can be removed in #2177 but I wanted to add tests before that PR

Changes are visible to end-users: no

Test plan

  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

@jbedard jbedard requested review from dzbarsky and thesayyn April 21, 2025 21:29
@aspect-workflows
Copy link

aspect-workflows bot commented Apr 21, 2025

Test

2 test targets passed

Targets
//npm/private:_test_gendocs_0_0 [k8-fastbuild] 30ms
//npm/private:_test_gendocs_0_1 [k8-fastbuild] 25ms

Total test execution time was 55ms. 223 tests (99.1%) were fully cached saving 33s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 502ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 151ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 2s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 448ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 533ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 268ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 603ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 98ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 253ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

42 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 2s.


Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 404ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 187ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 173ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 99ms.


Buildifier      Format

Add tests for the scenario fixed in aspect-build@a8c192e
Fix the issue when reproduced in pnpm v9+
@jbedard jbedard merged commit 5931c56 into aspect-build:main Apr 21, 2025
99 checks passed
@jbedard jbedard deleted the pnpm-link-peers branch April 21, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants