Skip to content

Conversation

liam-oldershaw-ctct
Copy link

Description

  • Triggers the custom parser for Messages that are defined inside of the channel of an operation

Related issue(s)
Resolves: #1099

Copy link

changeset-bot bot commented Jul 10, 2025

⚠️ No Changeset found

Latest commit: a87a06a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@liam-oldershaw-ctct liam-oldershaw-ctct changed the title Update parse-schema.ts fix: Update parse-schema.ts Jul 10, 2025
@liam-oldershaw-ctct liam-oldershaw-ctct changed the title fix: Update parse-schema.ts fix: update parse-schema.ts Jul 10, 2025
@liam-oldershaw-ctct liam-oldershaw-ctct changed the title fix: update parse-schema.ts fix: trigger custom schema on messages only defined in a channel of an operation Jul 10, 2025
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great catch. Appreciate the fix 🙏 Would you mind adding tests to cover this so it won't happen again by mistake?

Copy link

sonarqubecloud bot commented Aug 5, 2025

@liam-oldershaw-ctct
Copy link
Author

@fmvilas while writing the unit test I've noticed that the schema also doesn't get an anonymous id like the tests above.. So that might be another issue (not sure how important though)

@fmvilas
Copy link
Member

fmvilas commented Aug 11, 2025

@fmvilas while writing the unit test I've noticed that the schema also doesn't get an anonymous id like the tests above.. So that might be another issue (not sure how important though)

You probably caught another issue, yeah. Would you mind adding a separate PR for that? I think a small and focused PR is always better.

@liam-oldershaw-ctct
Copy link
Author

liam-oldershaw-ctct commented Aug 11, 2025

@jonaslagoni, @magicmatatjahu, and/or @smoya. can i get eyes on this please. I'll spend some time on the other issue

Edit: Ahh, i see the issue around updating the repo maintainers. Apologies, All good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Custom Parsers aren't triggered on payloads that are defined though Operations.Channel
2 participants