-
-
Notifications
You must be signed in to change notification settings - Fork 108
fix: trigger custom schema on messages only defined in a channel of an operation #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great catch. Appreciate the fix 🙏 Would you mind adding tests to cover this so it won't happen again by mistake?
… only definined in an operations channel
|
@fmvilas while writing the unit test I've noticed that the schema also doesn't get an anonymous id like the tests above.. So that might be another issue (not sure how important though) |
You probably caught another issue, yeah. Would you mind adding a separate PR for that? I think a small and focused PR is always better. |
Edit: Ahh, i see the issue around updating the repo maintainers. Apologies, All good |
Description
Related issue(s)
Resolves: #1099