[Don't merge] feat: Support for Multiple Custom Domains #1113
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1113 +/- ##
==========================================
+ Coverage 80.11% 80.14% +0.02%
==========================================
Files 131 131
Lines 4878 4875 -3
Branches 959 958 -1
==========================================
- Hits 3908 3907 -1
+ Misses 562 561 -1
+ Partials 408 407 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kushalshit27
changed the title
- Standardize TypeScript ignore comments with proper spacing - Standardize inline comment formatting with consistent spacing - Add comprehensive test coverage for custom domain update functionality
kushalshit27
changed the title
kushalshit27
changed the title
| customDomains: | ||
| - domain: my_domain.com | ||
| type: auth0_managed_certs | ||
| domain_metadata: |
There was a problem hiding this comment.
Can we include tls_policy too..?
| stripCreateFields: ['status', 'primary', 'verification'], | ||
| stripUpdateFields: [ | ||
| 'status', |
There was a problem hiding this comment.
I also see another field name certificate(read-only field similar to verification) in tf-provider PR, Any reason on not including in deploy-cli..?
There was a problem hiding this comment.
Sure, this was not added in the previous implementation, but we can add it now.
There was a problem hiding this comment.
I saw it being added in the stripUpdateFields , but not in the schema
There was a problem hiding this comment.
Yes, because the schema is used for input validation, certificate does not need validation.
| status: 'ready', // should be stripped | ||
| primary: true, // should be stripped | ||
| verification: { method: 'cname' }, // should be stripped | ||
| verification_method: 'cname', // should be stripped |
There was a problem hiding this comment.
Why do we have verification_method field separately in domain.. As we already have a field method in verifications!
There was a problem hiding this comment.
verification and verification_method can co-exist in the configuration at the same time. This function tests that they are stripped properly, as per our logic during update.
…auth0-deploy-cli into DXCDT-1075-mcd-ea-support
TODO: update node-sdk🔧 Changes
Example:
customDomains: - domain: my_domain.com ..................... + domain_metadata: + myKey: value📌 Note:
primaryfield is deprecated and may be removed in future versions.verification_methodfield is deprecated and may be removed in future versions.📚 References
🔬 Testing
TDB
📝 Checklist