Feature/add stl support #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was hesitant to submit as I see this will conflict with #9 once it's merged |
autopawn
requested changes
Jun 17, 2023
src/model.c
Outdated
|
|
||
| // Read facet definitions, 50 bytes each, facet normal, 3 vertices, and a 2 byte spacer | ||
| char buffer[50]; | ||
| while(fread(buffer, sizeof(char), 50, fp)) |
There was a problem hiding this comment.
Should we make sure that this call to fread returns 50?
There was a problem hiding this comment.
Same for the previous
fread(facetCount, sizeof(int), 1, fp);
There was a problem hiding this comment.
If we successfully read some facet data but at some point fread fails to read the 50 bytes, should we output the error but display what we have processed, or just output the error and return null?
There was a problem hiding this comment.
I think we should just display an error, indicating the premature end of the file. Since it is unlikely that fread fails.
WARNING to WARN for consistent output Use type rather then expression sizeof as it will never change Output error if fread fails to read the facet count check fread reads all 50 bytes of facet data before processing Add note assuming little-endian hardware
Add warning that color is not supported if --color argument passed to stl import
Correct winding order
PascalGilbraith
force-pushed
the
feature/add_stl_support
branch
from
95640b5 to
bf605ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for binary and ASCII STL files