Fix category position #296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During initCategories, the position of the next child for every category is retrieved from the db and updated during the import. If the position is not in the import data, the next_child_position is used and updated. When an existing category is moved from one parent to another, it also gets a new position
barbazul
reviewed
Jun 7, 2017
|
|
||
| $entityId = $this->_categoriesWithRoots[$rowData[self::COL_ROOT]][$rowData[self::COL_CATEGORY]]['entity_id']; | ||
| $path = $parentCategory['path'] .'/'.$entityId; | ||
| $position = $this->_categoriesWithRoots[$rowData[self::COL_ROOT]][self::COL_CATEGORY]['position']; |
There was a problem hiding this comment.
I think the second level key in the array was meant to be $rowData[self::COL_CATEGORY]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #281.
During initCategories, the position of the next child for every category is retrieved from the db and updated during the import. If the position is not in the import data, the next_child_position is used and updated.
When an existing category is moved from one parent to another, it also gets a new position
We have a slightly different implementation of the category entity adapter, so someone should still test this.