-
Notifications
You must be signed in to change notification settings - Fork 423
Added Acing the Frontend Interview #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added Acing the Frontend Interview #229
Conversation
Hi, Stjepan from Manning here. I thought this title might be a good match for your list. Thank you for considering it. Best,
WalkthroughA documentation-only update adds a new book entry, “Acing the Frontend Interview,” with a link to Manning, under the Books section of README.md. No code, API, or behavioral changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
373-373
: Place the new book in alphabetical order within Books.Awesome lists prefer alphabetical sorting. Move this entry to the top of the Books list to keep ordering consistent.
## Books :books: +* [Acing the Frontend Interview](https://www.manning.com/books/acing-the-frontend-interview) – Stand out from the crowd in frontend interviews. * [CSS: The Definitive Guide, 4th Edition](http://shop.oreilly.com/product/0636920012726.do) - Visual Presentation for the Web * [CSS: The Missing Manual](http://shop.oreilly.com/product/0636920036357.do) – Really Helpful in Advancing your Design Skills to a whole new Level * [CSS Secrets](http://shop.oreilly.com/product/0636920031123.do) – Better Solutions to Everyday Web Design Problems * [Every Layout: Relearn CSS Layout](https://every-layout.dev/) – Solving responsive layout problems using algorithmic design. * [Tiny CSS Projects](https://www.manning.com/books/tiny-css-projects) – Improve the way you write CSS as you build 12 tiny projects. - -* [Acing the Frontend Interview](https://www.manning.com/books/acing-the-frontend-interview) – Stand out from the crowd in frontend interviews.
373-373
: Confirm list-marker style vs markdownlint MD004.Static analysis flags “Expected: dash; Actual: asterisk”, but this file predominantly uses asterisks. Either keep asterisks and adjust markdownlint config, or switch the entire file in a separate PR—don’t mix markers within a section.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
373-373: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
🔇 Additional comments (1)
README.md (1)
373-373
: Scope check: is this book CSS-focused enough for this list?The title targets frontend interviews broadly, not CSS specifically. Please confirm it aligns with the list’s scope or suggest a more fitting section.
Hi,
Stjepan from Manning here. I thought this title might be a good match for your list. Thank you for considering it.
Best,
What does this PR do?
Which issue is this PR related to?
Does this PR follows our contribution guidelines?
Summary by CodeRabbit