Skip to content

Conversation

reedham-aws
Copy link
Contributor

The package was not linted previously. Running npm run lint yielded 182 linting errors, so I ran npm run lint:fix and fixed the rest manually.

There is only one lint fix that is worth noting: 2998bd2 adds logging to a catch block that was previously empty, but meant to continue on after catching the error.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@reedham-aws reedham-aws force-pushed the lint branch 3 times, most recently from 383dd11 to e28209a Compare August 20, 2025 23:25
Copy link
Contributor

@greyshi greyshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the linting fixes. Overall this looks good. Have you looked at that failing check for git diff? We can merge this after that's fixed

@reedham-aws
Copy link
Contributor Author

Trying to look right now, can't really figure out what the failure is as I built before committing and the commit includes the latest dist/index.js from my local.

@reedham-aws reedham-aws marked this pull request as ready for review August 20, 2025 23:38
@reedham-aws reedham-aws merged commit 06e3b62 into aws-actions:main Aug 20, 2025
7 checks passed
@reedham-aws reedham-aws deleted the lint branch August 20, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants