Skip to content

Write CSV with no vulns #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Write CSV with no vulns #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73a7b62
reproducing issue - test 1
Aug 30, 2024
868c842
resolve issue 85 - test 2
Aug 30, 2024
fdaa8ba
test 3
Aug 30, 2024
e2531cf
test fix
Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test_containers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ jobs:
uses: aws-actions/vulnerability-scan-github-action-for-amazon-inspector@v1.1.3
with:
artifact_type: 'container'
artifact_path: 'ubuntu:14.04'
artifact_path: 'alpine:latest'
display_vulnerability_findings: "enabled"
sbomgen_version: "1.3.1"
sbomgen_version: "1.4.0"

- name: Display scan results
run: cat ${{ steps.inspector.outputs.inspector_scan_results }}
- name: Display scan results (CSV)
run: cat ${{ steps.inspector.outputs.inspector_scan_results_csv }}

- name: Validate scan content
run: python3 validator/validate_inspector_scan.py --file ${{ steps.inspector.outputs.inspector_scan_results }}
Expand Down
4 changes: 0 additions & 4 deletions entrypoint/entrypoint/orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,6 @@ def install_sbomgen(args):


def write_pkg_vuln_report_csv(out_scan_csv, scan_result: exporter.InspectorScanResult):
if scan_result.total_vulns() == 0:
logging.info("skipping package vulnerability CSV report because no vulnerabilities were detected")
return

csv_output = exporter.to_csv(scan_result)

logging.info(f"writing package vulnerability CSV report to: {out_scan_csv}")
Expand Down
Loading