[DevTools] PR3.4 Logs NEW #2939
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 1, 2025 12:34
|
ShadowCat567
reviewed
Aug 1, 2025
| @@ -2,7 +2,7 @@ | |||
| "defaultDevPackages": [ | |||
| "@aws-amplify/backend", | |||
| "@aws-amplify/backend-cli", | |||
| "aws-cdk-lib@2.204.0", | |||
| "aws-cdk-lib@2.201.0", | |||
There was a problem hiding this comment.
Any particular reason why aws-cdk-lib is getting downgraded here?
| @@ -516,6 +516,8 @@ export class SandboxDevToolsCommand implements CommandModule<object> { | |||
| shutdownService, | |||
| resourceService, | |||
| storageManager, | |||
| undefined, | |||
| undefined, | |||
There was a problem hiding this comment.
I am assuming these are activeLogPollers and toggleStartTimes, do they get defined later on?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this pull request: #2914
Same as above PR, but moved changes to an unstream branch instead of a personal fork