fix: make URLRequest property thread safe #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisabhash
reviewed
Jul 2, 2025
Tests/AWSAppSyncApolloExtensionsTests/Websocket/AppSyncWebSocketClientTests.swift
Outdated
Show resolved
Hide resolved
Tests/AWSAppSyncApolloExtensionsTests/Websocket/AppSyncWebSocketClientTests.swift
Show resolved
Hide resolved
Tests/AWSAppSyncApolloExtensionsTests/Websocket/AppSyncWebSocketClientTests.swift
Outdated
Show resolved
Hide resolved
thisisabhash
changed the title
thisisabhash
changed the title
anthonyguella
force-pushed
the
bugfix-37/requestRaceCondition
branch
from
398eb88 to
d78ad56
Compare
anthonyguella
force-pushed
the
bugfix-37/requestRaceCondition
branch
from
d78ad56 to
6a2c080
Compare
[Changes] - Wrapped the AppSyncWebSocketClient request in a lock, providing thread safe access. This prevents a potential crash from concurrent read/writes. [Testing] - Verified solution is working via a unit test. Motivation: aws-amplify#37
anthonyguella
force-pushed
the
bugfix-37/requestRaceCondition
branch
from
6a2c080 to
829be6a
Compare
thisisabhash
approved these changes
Jul 2, 2025
|
Successful integration test run: https://github.com/aws-amplify/aws-appsync-apollo-extensions-swift/actions/runs/16034942305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#37
Description of changes:
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.