Styling fix for artifact uploader #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongyamazon
force-pushed
the
rongy-upload-followup
branch
4 times, most recently
from
74dea22 to
4d5168f
Compare
satyakigh
reviewed
Nov 6, 2025
rongyamazon
force-pushed
the
rongy-upload-followup
branch
2 times, most recently
from
1dd55e6 to
1d12c3b
Compare
chrisqm-dev
previously approved these changes
Nov 10, 2025
satyakigh
force-pushed
the
rongy-upload-followup
branch
from
1d12c3b to
03d8bb6
Compare
rongyamazon
force-pushed
the
rongy-upload-followup
branch
from
03d8bb6 to
090fe6d
Compare
satyakigh
reviewed
Nov 12, 2025
Zee2413
approved these changes
Nov 13, 2025
tylerymarkowitz
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Follow up for previous CR, styling fix for artifact uploader
Description of changes:
Fixed styling issue from previous uploader PR: #202
One thing to note is I've removed the magic numbers check for zip file and only rely on the file extension after talking to the team
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.