Skip to content

Promote ResourceAdoption and ReadOnlyResources features from Alpha to Beta status #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rushmash91
Copy link
Member

Description of changes:

  • Promote ResourceAdoption and ReadOnlyResources features from Alpha to Beta status

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and michaelhtm August 11, 2025 23:29
@ack-prow ack-prow bot added the approved label Aug 11, 2025
@rushmash91
Copy link
Member Author

rushmash91 commented Aug 11, 2025

weird Error: cannot clone repository: context deadline exceeded: take too long to clone aws sdk repo, please consider manually 'git clone https://github.com/aws/aws-sdk-go-v2' to cache dir /root/.cache/aws-controllers-k8s/src/aws-sdk-go-v2

/retest

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025
Copy link

ack-prow bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rushmash91
Copy link
Member Author

/test eks-controller-test

Copy link

ack-prow bot commented Aug 12, 2025

@rushmash91: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 88010c1 link false /test verify-attribution
s3-olm-test 88010c1 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91
Copy link
Member Author

/test eks-controller-test

@ack-prow ack-prow bot merged commit dd7115d into aws-controllers-k8s:main Aug 12, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants