Skip to content
Open
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ If your change does not need a CHANGELOG entry, add the "skip changelog" label t

### Enhancements

- Port CloudWatch EMF metrics exporter to Java
([#1209](https://github.com/aws-observability/aws-otel-java-instrumentation/pull/1209))
- Support X-Ray Trace Id extraction from Lambda Context object, and respect user-configured OTEL_PROPAGATORS in AWS Lamdba instrumentation
([#1191](https://github.com/aws-observability/aws-otel-java-instrumentation/pull/1191)) ([#1218](https://github.com/aws-observability/aws-otel-java-instrumentation/pull/1218))
- Adaptive Sampling improvements: Ensure propagation of sampling rule across services and AWS accounts. Remove unnecessary B3 propagator.
Expand Down
2 changes: 2 additions & 0 deletions awsagentprovider/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ dependencies {
runtimeOnly("software.amazon.awssdk:sts")
implementation("software.amazon.awssdk:auth")
implementation("software.amazon.awssdk:http-auth-aws")
// For EMF exporter
implementation("software.amazon.awssdk:cloudwatchlogs")

testImplementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
testImplementation("io.opentelemetry:opentelemetry-sdk-testing")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,45 @@
import static software.amazon.opentelemetry.javaagent.providers.AwsApplicationSignalsCustomizerProvider.*;

import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.Arrays;
import java.util.*;
import java.util.logging.Level;
import java.util.logging.Logger;
import java.util.regex.Pattern;

/** Utilities class to validate ADOT environment variable configuration. */
public final class AwsApplicationSignalsConfigValidator {
public final class AwsApplicationSignalsConfigUtils {
private static final Logger logger =
Logger.getLogger(AwsApplicationSignalsCustomizerProvider.class.getName());

/**
* Removes "awsemf" from OTEL_METRICS_EXPORTER if present to prevent validation errors from OTel
* dependencies which would try to load metric exporters. We will contribute emf exporter to
* upstream for supporting OTel metrics in SDK
*
* @param configProps the configuration properties
* @return Optional containing string with "awsemf" removed if the original OTEL_METRICS_EXPORTER
* contains "awsemf", otherwise empty Optional if "awsemf" is not found
*/
static Optional<String> removeEmfExporterIfEnabled(ConfigProperties configProps) {
String metricExporters = configProps.getString(OTEL_METRICS_EXPORTER);

if (metricExporters == null || !metricExporters.contains("awsemf")) {
return Optional.empty();
}

String[] exporters = metricExporters.split(",");
List<String> filtered =
Arrays.stream(exporters)
.map(String::trim)
.filter(exp -> !exp.equals("awsemf"))
.collect(java.util.stream.Collectors.toList());

// Return empty string instead of "none" because upstream will not call
// customizeMetricExporter if OTEL_METRICS_EXPORTER is set to "none" as it assumes
// no metrics exporter is configured
return Optional.of(filtered.isEmpty() ? "" : String.join(",", filtered));
}

/**
* Is the given configuration correct to enable SigV4 for Logs?
*
Expand Down Expand Up @@ -61,27 +90,21 @@ static boolean isSigV4EnabledLogs(ConfigProperties config) {

if (logsHeaders == null || logsHeaders.isEmpty()) {
logger.warning(
"Improper configuration: Please configure the environment variable OTEL_EXPORTER_OTLP_LOGS_HEADERS to include x-aws-log-group and x-aws-log-stream");
String.format(
"Improper configuration: Please configure the environment variable OTEL_EXPORTER_OTLP_LOGS_HEADERS to include %s and %s",
AWS_OTLP_LOGS_GROUP_HEADER, AWS_OTLP_LOGS_STREAM_HEADER));

return false;
}
Map<String, String> parsedHeaders =
AwsApplicationSignalsConfigUtils.parseOtlpHeaders(logsHeaders);

long filteredLogHeaders =
Arrays.stream(logsHeaders.split(","))
.filter(
pair -> {
if (pair.contains("=")) {
String key = pair.split("=", 2)[0];
return key.equals(AWS_OTLP_LOGS_GROUP_HEADER)
|| key.equals(AWS_OTLP_LOGS_STREAM_HEADER);
}
return false;
})
.count();

if (filteredLogHeaders != 2) {
if (!(parsedHeaders.containsKey(AWS_OTLP_LOGS_GROUP_HEADER)
&& parsedHeaders.containsKey(AWS_OTLP_LOGS_STREAM_HEADER))) {
logger.warning(
"Improper configuration: Please configure the environment variable OTEL_EXPORTER_OTLP_LOGS_HEADERS to have values for x-aws-log-group and x-aws-log-stream");
String.format(
"Improper configuration: Please configure the environment variable OTEL_EXPORTER_OTLP_LOGS_HEADERS to have values for %s and %s",
AWS_OTLP_LOGS_GROUP_HEADER, AWS_OTLP_LOGS_STREAM_HEADER));
return false;
}

Expand Down Expand Up @@ -168,4 +191,26 @@ private static boolean isSigv4ValidConfig(

return false;
}

/**
* Parse OTLP headers and return a map of header key to value. See: <a
* href="https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#otel_exporter_otlp_headers">...</a>
*
* @param headersString the headers string in format "key1=value1,key2=value2"
* @return map of header keys to values
*/
static Map<String, String> parseOtlpHeaders(String headersString) {
Map<String, String> headers = new HashMap<>();
if (headersString == null || headersString.isEmpty()) {
return headers;
}

for (String pair : headersString.split(",")) {
if (pair.contains("=")) {
String[] keyValue = pair.split("=", 2);
headers.put(keyValue[0].trim(), keyValue[1].trim());
}
}
return headers;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
import java.util.logging.Level;
import java.util.logging.Logger;
import javax.annotation.concurrent.Immutable;
import software.amazon.opentelemetry.javaagent.providers.exporter.aws.metrics.AwsCloudWatchEmfExporter;
import software.amazon.opentelemetry.javaagent.providers.exporter.otlp.aws.logs.OtlpAwsLogsExporterBuilder;
import software.amazon.opentelemetry.javaagent.providers.exporter.otlp.aws.traces.OtlpAwsSpanExporterBuilder;

Expand All @@ -86,6 +87,9 @@
@Immutable
public final class AwsApplicationSignalsCustomizerProvider
implements AutoConfigurationCustomizerProvider {
// https://docs.aws.amazon.com/cli/v1/userguide/cli-configure-envvars.html
static final String AWS_REGION = "aws.region";
static final String AWS_DEFAULT_REGION = "aws.default.region";
static final String AWS_LAMBDA_FUNCTION_NAME_CONFIG = "AWS_LAMBDA_FUNCTION_NAME";
static final String LAMBDA_APPLICATION_SIGNALS_REMOTE_ENVIRONMENT =
"LAMBDA_APPLICATION_SIGNALS_REMOTE_ENVIRONMENT";
Expand All @@ -103,6 +107,7 @@ public final class AwsApplicationSignalsCustomizerProvider
// https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch-OTLPEndpoint.html#CloudWatch-LogsEndpoint
static final String AWS_OTLP_LOGS_GROUP_HEADER = "x-aws-log-group";
static final String AWS_OTLP_LOGS_STREAM_HEADER = "x-aws-log-stream";
static final String AWS_EMF_METRICS_NAMESPACE = "x-aws-metric-namespace";

private static final String DEPRECATED_SMP_ENABLED_CONFIG = "otel.smp.enabled";
private static final String DEPRECATED_APP_SIGNALS_ENABLED_CONFIG =
Expand Down Expand Up @@ -132,7 +137,7 @@ public final class AwsApplicationSignalsCustomizerProvider
private static final String OTEL_BSP_MAX_EXPORT_BATCH_SIZE_CONFIG =
"otel.bsp.max.export.batch.size";

private static final String OTEL_METRICS_EXPORTER = "otel.metrics.exporter";
static final String OTEL_METRICS_EXPORTER = "otel.metrics.exporter";
static final String OTEL_LOGS_EXPORTER = "otel.logs.exporter";
static final String OTEL_TRACES_EXPORTER = "otel.traces.exporter";
static final String OTEL_EXPORTER_OTLP_TRACES_PROTOCOL = "otel.exporter.otlp.traces.protocol";
Expand Down Expand Up @@ -161,6 +166,7 @@ public final class AwsApplicationSignalsCustomizerProvider
private static final int LAMBDA_SPAN_EXPORT_BATCH_SIZE = 10;

private Sampler sampler;
private boolean isEmfExporterEnabled = false;

public void customize(AutoConfigurationCustomizer autoConfiguration) {
autoConfiguration.addPropertiesCustomizer(this::customizeProperties);
Expand All @@ -171,6 +177,15 @@ public void customize(AutoConfigurationCustomizer autoConfiguration) {
autoConfiguration.addMeterProviderCustomizer(this::customizeMeterProvider);
autoConfiguration.addSpanExporterCustomizer(this::customizeSpanExporter);
autoConfiguration.addLogRecordExporterCustomizer(this::customizeLogsExporter);
autoConfiguration.addMetricExporterCustomizer(this::customizeMetricExporter);
}

private static Optional<String> getAwsRegionFromConfig(ConfigProperties configProps) {
String region = configProps.getString(AWS_REGION);
if (region != null) {
return Optional.of(region);
}
return Optional.ofNullable(configProps.getString(AWS_DEFAULT_REGION));
}

static boolean isLambdaEnvironment() {
Expand All @@ -190,10 +205,18 @@ private boolean isApplicationSignalsRuntimeEnabled(ConfigProperties configProps)
&& configProps.getBoolean(APPLICATION_SIGNALS_RUNTIME_ENABLED_CONFIG, true);
}

private Map<String, String> customizeProperties(ConfigProperties configProps) {
Map<String, String> customizeProperties(ConfigProperties configProps) {
Map<String, String> propsOverride = new HashMap<>();
boolean isLambdaEnvironment = isLambdaEnvironment();

// Check if awsemf was specified and remove it from OTEL_METRICS_EXPORTER
Optional<String> filteredExporters =
AwsApplicationSignalsConfigUtils.removeEmfExporterIfEnabled(configProps);
if (filteredExporters.isPresent()) {
this.isEmfExporterEnabled = true;
propsOverride.put(OTEL_METRICS_EXPORTER, filteredExporters.get());
}

// Enable AWS Resource Providers
propsOverride.put(OTEL_RESOURCE_PROVIDERS_AWS_ENABLED, "true");

Expand Down Expand Up @@ -394,7 +417,6 @@ private SdkTracerProviderBuilder customizeTracerProviderBuilder(

private SdkMeterProviderBuilder customizeMeterProvider(
SdkMeterProviderBuilder sdkMeterProviderBuilder, ConfigProperties configProps) {

if (isApplicationSignalsRuntimeEnabled(configProps)) {
Set<String> registeredScopeNames = new HashSet<>(1);
String jmxRuntimeScopeName = "io.opentelemetry.jmx";
Expand Down Expand Up @@ -434,7 +456,7 @@ SpanExporter customizeSpanExporter(SpanExporter spanExporter, ConfigProperties c
}
}

if (AwsApplicationSignalsConfigValidator.isSigV4EnabledTraces(configProps)) {
if (AwsApplicationSignalsConfigUtils.isSigV4EnabledTraces(configProps)) {
// can cast here since we've checked that the configuration for OTEL_TRACES_EXPORTER is otlp
// and OTEL_EXPORTER_OTLP_TRACES_PROTOCOL is http/protobuf
// so the given spanExporter will be an instance of OtlpHttpSpanExporter
Expand Down Expand Up @@ -480,7 +502,7 @@ private boolean isOtlpSpanExporter(SpanExporter spanExporter) {

LogRecordExporter customizeLogsExporter(
LogRecordExporter logsExporter, ConfigProperties configProps) {
if (AwsApplicationSignalsConfigValidator.isSigV4EnabledLogs(configProps)) {
if (AwsApplicationSignalsConfigUtils.isSigV4EnabledLogs(configProps)) {
// can cast here since we've checked that the configuration for OTEL_LOGS_EXPORTER is otlp and
// OTEL_EXPORTER_OTLP_LOGS_PROTOCOL is http/protobuf
// so the given logsExporter will be an instance of OtlpHttpLogRecorderExporter
Expand Down Expand Up @@ -509,6 +531,41 @@ LogRecordExporter customizeLogsExporter(
return logsExporter;
}

MetricExporter customizeMetricExporter(
MetricExporter metricExporter, ConfigProperties configProps) {
if (isEmfExporterEnabled) {
Map<String, String> headers =
AwsApplicationSignalsConfigUtils.parseOtlpHeaders(
configProps.getString(OTEL_EXPORTER_OTLP_LOGS_HEADERS));
Optional<String> awsRegion = getAwsRegionFromConfig(configProps);

if (awsRegion.isPresent()) {
if (headers.containsKey(AWS_OTLP_LOGS_GROUP_HEADER)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does customer have to set all 3 headers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed validation for namespace header.

&& headers.containsKey(AWS_OTLP_LOGS_STREAM_HEADER)
&& headers.containsKey(AWS_EMF_METRICS_NAMESPACE)) {
String namespace = headers.get(AWS_EMF_METRICS_NAMESPACE);
String logGroup = headers.get(AWS_OTLP_LOGS_GROUP_HEADER);
String logStream = headers.get(AWS_OTLP_LOGS_STREAM_HEADER);
return new AwsCloudWatchEmfExporter(namespace, logGroup, logStream, awsRegion.get());
}
logger.warning(
String.format(
"Improper configuration: Please configure the environment variable OTEL_EXPORTER_OTLP_LOGS_HEADERS to have values for %s, %s, and %s",
AWS_OTLP_LOGS_GROUP_HEADER,
AWS_OTLP_LOGS_STREAM_HEADER,
AWS_EMF_METRICS_NAMESPACE));

} else {
logger.warning(
String.format(
"Improper configuration: AWS region not found in environment variables please set %s or %s",
AWS_REGION, AWS_DEFAULT_REGION));
}
}

return metricExporter;
}

static AwsXrayAdaptiveSamplingConfig parseConfigString(String config)
throws JsonProcessingException {
if (config == null) {
Expand Down
Loading
Loading