Skip to content

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Feb 25, 2025

Please provide the issue number

Issue number: #781

Summary

Changes

Add POWERTOOLS_METRICS_DISABLED support to disable Metrics to be emited

User experience

Set POWERTOOLS_METRICS_DISABLED environment variable to true

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig February 25, 2025 11:24
@boring-cyborg boring-cyborg bot added area/common Core Powertools utility area/metrics Core metrics utility documentation Improvements or additions to documentation github-actions Changes in GitHub workflows internal Maintenance changes tests labels Feb 25, 2025
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 25, 2025
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2025
@hjgraca hjgraca self-assigned this Feb 27, 2025
Copy link

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.02%. Comparing base (75ee06b) to head (f2e94df).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #786   +/-   ##
========================================
  Coverage    74.02%   74.02%           
========================================
  Files          210      210           
  Lines         8396     8404    +8     
  Branches       907      910    +3     
========================================
+ Hits          6215     6221    +6     
- Misses        1883     1884    +1     
- Partials       298      299    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjgraca hjgraca merged commit 08efcb2 into aws-powertools:develop Feb 27, 2025
11 checks passed
@hjgraca hjgraca deleted the feature/metrics-disabled branch February 27, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/common Core Powertools utility area/metrics Core metrics utility documentation Improvements or additions to documentation github-actions Changes in GitHub workflows internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Metrics - environment variable to allow customer disable custom metrics
2 participants