Skip to content

Issue 157: FIX:CWE-117,93 Log injection in PostgreSQL lambda_function.py #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seetamraju
Copy link

Issue # 157

Description of changes:
HIGH-Severity Security Vulnerability from AWS-Inspector.
CWE-117,93 Log injection

Analysis:

HIGH-Severity Security Vulnerability from AWS-Inspector.
CWE-117,93 Log injection
The PostgreSQL-related Lambdas have 3 "input" variables: arn token and step.
With no attempt to sanitize these inputs, these variables are logged using logger.


*Even tho' these lambdas are NOT expected to be connected to APIGW, and are meant to be invoked via EventBridge-Cron, .. the AWS-Inspector, and other security-tools, will NEVER be able to confirm this, and so will continue to flag ALL Log-related vulnerabilities as high.

Since the FIX is trivial (add .encode() to EACH and EVERY logger-statement) and .. ..
.. Since the primary-code is UNTOUCHED (as in, we are NOT choosing to "fix" these 3 input-variables), ..
it is quite reasonable to conclude that there should be ZERO functional impact (that is, No new errors introduced).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants