Stage/Upload Lambda Layer when --solution_directory argument provided #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I messed up my branching with this pull request. I've recreated them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few clarifying updates to the documentation.
Bug fix for: Issue 156
Currently, the script does not deploy a lambda code layer directory when the --solution_directory argument is passed. I've updated the logic to add this.
Update for: Issue 273
Currently, in Control Tower enabled environments, the sra-easy-setup deploys a control tower custom role for the ConfigRecorder and is picked up as a Critical finding in SecurityHub because security guidance recommends the use of a service linked role. The custom role however only has a Config managed policy applied to it.
Because this managed policy doesn't appear to provide additional access not included in the ConfigRecorder service linked role, I've replaced the custom role with the service linked role.
By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].
Apache 2.0 License