Add ECS Service Linked Role to sandbox accounts #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures ECS clusters can be created in the sandbox account without permission issues by adding the ECS service-linked role to the Nuke configuration. This prevents Nuke from deleting the role and causing issues when creating ECS clusters.
Simplifies the creation of the ECS service-linked role by using `CfnServiceLinkedRole` instead of manually defining the role and its policies. This change also removes unnecessary suppressions for cfn-guard, as the `CfnServiceLinkedRole` doesn't support `cfnOptions`. The nuke config is also updated to reflect the changes.
|
Hi @aws-khargita ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds ECS Service Linked Role (
AWSServiceRoleForECS) to sandbox account resources to resolve ECS cluster creation failuresChanges
CfnServiceLinkedRolefor ECS service inIsbSandboxAccountResourcesIAMServiceLinkedRolein nuke-config.yamlProblem Solved
Fixes "Unable to assume the service linked role" error when creating ECS clusters in sandbox accounts.
Testing