-
Notifications
You must be signed in to change notification settings - Fork 633
Support EBS Task Attach non-root user mode #4757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineonine
previously approved these changes
Aug 18, 2025
singholt
requested changes
Aug 18, 2025
42d1547
to
558b9de
Compare
558b9de
to
b1f68e0
Compare
singholt
reviewed
Aug 25, 2025
singholt
previously approved these changes
Aug 25, 2025
singholt
previously approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont forget to squash your commits when merging this PR.
06512a7
to
c35f952
Compare
ShelbyZ
reviewed
Aug 26, 2025
singholt
approved these changes
Aug 28, 2025
ShelbyZ
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables running ECS EC2 Tasks with EBS Task Attach Enabled as a Non Root User. The change allows the Non Root User inside of the running container to write to the attached EBS Volume.
Implementation details
SourceVolumeHostPath
--group-add
NodeStageVolume
, sets the mount point ownership to this GID usingchown
and sets permissions to 775 withsetgid
bit usingchmod
ecs.capability.storage.ebsta-non-root-user
during instance registration. This helps ECS back-end find a capable instance during task placement.Testing
New tests cover the changes: Yes
Description for the changelog
Feature: Support EBS task attach non-root user mode
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions? No
Does this PR include the addition of new environment variables in the README? No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.