Get correct S3 URL suffix for EUSC regions in ecs-anywhere-install.sh #4761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShelbyZ
reviewed
Aug 21, 2025
ShelbyZ
approved these changes
Aug 21, 2025
prateekchaudhry
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update S3 URL suffix logic to be able to handle aws-eusc partition (remove hardcoded/always present "amazonaws.com").
Also define and consume reusable
is-cn-regionandis-eusc-regionfunctions to determine if a region is in aws-cn partition or in aws-eusc partition.Implementation details
N/A (see "Summary" section above)
Testing
Run ECS Anywhere install script in eusc-de-east-1 (aws-eusc region) on Amazon Linux 2. Verify script successfully reached correct S3 URL and is able to download all ECS Anywhere dependencies.
Description for the changelog
Enhancement: Get correct S3 URL suffix for EUSC regions in ecs-anywhere-install.sh
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.