Skip to content

feat(agentcore): add agentcore L2 constructs for 1p tools #35577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Oct 17, 2025
Merged

feat(agentcore): add agentcore L2 constructs for 1p tools #35577

merged 48 commits into from
Oct 17, 2025

Conversation

krokoko
Copy link
Contributor

@krokoko krokoko commented Sep 25, 2025 •
edited
Loading

Issue # (if applicable)

Related to aws/aws-cdk-rfcs#785

Reason for this change

Adding a new alpha package for Amazon Bedrock AgentCore and add support for 1p tools (Browser, Code Interpreter).

Description of changes

  • Create a new alpha package
  • Add L2 constructs for browser, code interpreter
  • Add documentation
  • Add tests

Describe any new or updated permissions being added

Using permissions for agent core defined in https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazonbedrockagentcore.html

Description of how you validated changes

Unit tests, integration tests, manual tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 25, 2025 17:30
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Sep 25, 2025
@krokoko
Copy link
Contributor Author

krokoko commented Sep 25, 2025

Build failures seem to come from other packages, not this contribution

@alvazjor alvazjor self-assigned this Sep 26, 2025
alvazjor
alvazjor previously requested changes Sep 29, 2025
View reviewed changes
@mergify mergify bot dismissed alvazjor’s stale review September 30, 2025 00:31

Pull request has been modified.

alvazjor
alvazjor previously requested changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also saw that the build is failing after the last round of changes due to low unit test coverage (or at least lower than expected). Lets make sure that gets fixed too please. Once we resolve all this, I think this construct will be ready and just waiting to be merged.

@mergify mergify bot dismissed alvazjor’s stale review September 30, 2025 17:04

Pull request has been modified.

alvazjor
alvazjor previously requested changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny change that shouldn't affect anything else. Once fixed this PR can be considered finished and approval ready at the current state. I know a modification will be needed once the VPC mode is released, but for now we are good to go

@krokoko krokoko requested a review from alvazjor October 2, 2025 12:36
@mergify mergify bot dismissed alvazjor’s stale review October 2, 2025 12:36

Pull request has been modified.

@krokoko krokoko had a problem deploying to deployment-integ-test October 9, 2025 16:00 — with GitHub Actions Error
alvazjor
alvazjor previously requested changes Oct 10, 2025
View reviewed changes
@mergify mergify bot dismissed alvazjor’s stale review October 10, 2025 14:43

Pull request has been modified.

@krokoko krokoko marked this pull request as ready for review October 10, 2025 14:47
@alvazjor alvazjor added the pr/do-not-merge This PR should not be merged at this time. label Oct 10, 2025
alvazjor
alvazjor previously approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@alvazjor alvazjor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR in current state. This PR belongs to RFC 797: Bedrock AgentCore Tools 1P L2 construct which has also been approved and is now in the Final Comments period. Once the RFC is closed, this PR will be merged

@mergify mergify bot dismissed alvazjor’s stale review October 14, 2025 14:37

Pull request has been modified.

@alvazjor alvazjor removed the pr/do-not-merge This PR should not be merged at this time. label Oct 17, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 17, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 17, 2025
@mergify mergify bot merged commit 3087ffa into aws:main Oct 17, 2025
26 of 28 checks passed
@mergify mergify bot removed the queued label Oct 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alvazjor alvazjor alvazjor approved these changes

Assignees

@alvazjor alvazjor

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krokoko @alvazjor